Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle issue on Windows with MsgPack dependency with Ruby 2.6 #186

Open
mattheworiordan opened this issue Aug 4, 2019 · 2 comments
Open
Labels
bug Something isn't working. It's clear that this does need to be fixed.

Comments

@mattheworiordan
Copy link
Member

mattheworiordan commented Aug 4, 2019

Customer reported a bundle issue with ruby 2.6 on windows

Resolving dependencies.....
Bundler could not find compatible versions for gem "unf_extmsgpack":
In Gemfile:
rest-client (~> 2.0, >= 2.0.2) was resolved to 2.0.2, which depends on
http-cookie (>= 1.0.2, < 2.0) was resolved to 1.0.3, which depends on
domain_name (~> 0.5) was resolved to 0.5.20180417, which depends on
unf (>= 0.0.5, < 1.0.0) was resolved to 0.1.4, which depends on
unf_extmsgpack

Could not find gem 'unf_extmsgpack', which is required by gem 'unf (>= 0.0.5, <
1.0.0)', in any of the sources.

┆Issue is synchronized with this Jira Bug by Unito

@mattheworiordan mattheworiordan added the bug Something isn't working. It's clear that this does need to be fixed. label Aug 4, 2019
mattheworiordan added a commit that referenced this issue Aug 4, 2019
Fix Windows bundle issue: #186
@mattheworiordan
Copy link
Member Author

Given at present Travis does not support Ruby on Windows https://docs.travis-ci.com/user/reference/windows/, it's unlikely we can fix this in the near future.

@mattheworiordan mattheworiordan added enhancement New feature or improved functionality. low_priority and removed bug Something isn't working. It's clear that this does need to be fixed. labels Aug 4, 2019
mattheworiordan added a commit to ably/ably-ruby-rest that referenced this issue Aug 5, 2019
Fix Windows bundle issue: ably/ably-ruby#186
mattheworiordan added a commit that referenced this issue Aug 6, 2019
Fix Windows bundle issue: #186
@sync-by-unito sync-by-unito bot removed the enhancement New feature or improved functionality. label Mar 27, 2023
@lawrence-forooghian lawrence-forooghian added the bug Something isn't working. It's clear that this does need to be fixed. label Apr 22, 2024
@lawrence-forooghian
Copy link
Collaborator

Hey @mattheworiordan, just taking a look at this one whilst prioritising bugs. I see that we don't explicitly advertise support for Windows in this SDK. But nor do we explicitly say "we only support Linux". Where does Windows support sit priority-wise?

I’m also a bit confused by this comment:

Given at present Travis does not support Ruby on Windows https://docs.travis-ci.com/user/reference/windows/, it's unlikely we can fix this in the near future.

I’m assuming Travis is what we used for CI at the time you wrote that comment. Was your comment meant to be something along the lines of "even if we were to fix this issue, we wouldn’t be able to test the fix in CI, so we won’t fix it"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working. It's clear that this does need to be fixed.
Development

Successfully merging a pull request may close this issue.

3 participants