Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spec: Don't assert error messages #432

Merged
merged 1 commit into from
Jul 24, 2024
Merged

spec: Don't assert error messages #432

merged 1 commit into from
Jul 24, 2024

Conversation

lmars
Copy link
Member

@lmars lmars commented Jul 23, 2024

They are subject to change, so checking the error code is enough to know that the expected error occurred.

They are subject to change, so checking the error code is enough to know
that the expected error occurred.

Signed-off-by: Lewis Marshall <lewis.marshall@ably.com>
Copy link
Contributor

@sacOO7 sacOO7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lmars lmars merged commit 7cd1083 into main Jul 24, 2024
23 checks passed
@lmars lmars deleted the spec-no-error-message branch July 24, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants