Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WEB-3426] Modernize docs to latest Ably-UI Standards #2251

Draft
wants to merge 29 commits into
base: main
Choose a base branch
from

Conversation

aralovelace
Copy link
Contributor

@aralovelace aralovelace commented Aug 28, 2024

Description

A PR description indicating the purpose of the PR.

WEB-3426

Review

Instructions on how to review the PR.

aleksandar-r and others added 26 commits August 28, 2024 11:52
Fix the export syntax and rename index.js to index.ts for it to
propagate as well
The styles are imported in the main stylesheet
Subtle differences in the order in which components were imported
between the base-template and the pub-sub how-to caused errors for
mini-css-extract, consolidating the order removed the warnings
…jects

issue: Currently highlight styles not generated as its not added as safelist correctly in the tailwind configuration
Co-Authored-By: Jamie Henson <1105768+jamiehenson@users.noreply.github.com>
Fix: The collapsable side nav is broken on this page
FIx : tiny bit of collision between 2 inline code items
@aralovelace aralovelace self-assigned this Aug 28, 2024
@ably-ci ably-ci temporarily deployed to ably-docs-web-3426-css--ynfyyk August 28, 2024 14:05 Inactive
@aralovelace aralovelace force-pushed the web-3426-css-changes-to-modernize-docs branch from 6fc72bd to 406c9ee Compare August 28, 2024 14:06
@aralovelace aralovelace temporarily deployed to ably-docs-next-staging August 28, 2024 14:07 Inactive
@aralovelace aralovelace temporarily deployed to ably-docs-web-3426-css--ynfyyk August 28, 2024 14:07 Inactive
@aralovelace aralovelace changed the title Web 3426 css changes to modernize docs [WEB-3426] Modernize docs to latest Ably-UI Standards Aug 28, 2024
right hand nav all appears super bold
@aralovelace aralovelace temporarily deployed to ably-docs-next-staging August 28, 2024 14:29 Inactive
@aralovelace aralovelace temporarily deployed to ably-docs-web-3426-css--ynfyyk August 28, 2024 14:29 Inactive
@aralovelace aralovelace temporarily deployed to ably-docs-next-staging August 29, 2024 10:20 Inactive
@aralovelace aralovelace temporarily deployed to ably-docs-web-3426-css--ynfyyk August 29, 2024 10:20 Inactive
@aralovelace aralovelace force-pushed the web-3426-css-changes-to-modernize-docs branch from 72498ea to adca1a8 Compare August 29, 2024 10:42
@aralovelace aralovelace temporarily deployed to ably-docs-web-3426-css--ynfyyk August 29, 2024 10:42 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants