Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WEB-3426] Modernize docs to latest Ably-UI Standards #2251

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

aralovelace
Copy link
Contributor

@aralovelace aralovelace commented Aug 28, 2024

Description

This PR bumps ably-ui to the latest version (14.7.8 at the time of writing), and with it solves various conflicts and regressions that come about via breaking changes introduced in later versions of ably-ui.

Review

Instructions on how to review the PR.

@aralovelace aralovelace self-assigned this Aug 28, 2024
@ably-ci ably-ci temporarily deployed to ably-docs-web-3426-css--ynfyyk August 28, 2024 14:05 Inactive
@aralovelace aralovelace force-pushed the web-3426-css-changes-to-modernize-docs branch from 6fc72bd to 406c9ee Compare August 28, 2024 14:06
@aralovelace aralovelace temporarily deployed to ably-docs-next-staging August 28, 2024 14:07 Inactive
@aralovelace aralovelace temporarily deployed to ably-docs-web-3426-css--ynfyyk August 28, 2024 14:07 Inactive
@aralovelace aralovelace changed the title Web 3426 css changes to modernize docs [WEB-3426] Modernize docs to latest Ably-UI Standards Aug 28, 2024
@aralovelace aralovelace temporarily deployed to ably-docs-next-staging August 28, 2024 14:29 Inactive
@aralovelace aralovelace temporarily deployed to ably-docs-web-3426-css--ynfyyk August 28, 2024 14:29 Inactive
@aralovelace aralovelace temporarily deployed to ably-docs-next-staging August 29, 2024 10:20 Inactive
@aralovelace aralovelace temporarily deployed to ably-docs-web-3426-css--ynfyyk August 29, 2024 10:20 Inactive
@aralovelace aralovelace force-pushed the web-3426-css-changes-to-modernize-docs branch from 72498ea to adca1a8 Compare August 29, 2024 10:42
@aralovelace aralovelace temporarily deployed to ably-docs-web-3426-css--ynfyyk August 29, 2024 10:42 Inactive
@aralovelace aralovelace temporarily deployed to ably-docs-next-staging August 29, 2024 10:42 Inactive
@jamiehenson jamiehenson force-pushed the web-3426-css-changes-to-modernize-docs branch from adca1a8 to 89d9894 Compare November 4, 2024 14:44
@jamiehenson jamiehenson temporarily deployed to ably-docs-next-staging November 4, 2024 14:52 Inactive
@jamiehenson jamiehenson force-pushed the web-3426-css-changes-to-modernize-docs branch from aefd249 to d3b142f Compare November 5, 2024 13:28
@jamiehenson jamiehenson temporarily deployed to ably-docs-next-staging November 5, 2024 13:28 Inactive
@jamiehenson jamiehenson temporarily deployed to ably-docs-next-staging November 5, 2024 14:33 Inactive
@jamiehenson jamiehenson temporarily deployed to ably-docs-next-staging November 5, 2024 17:28 Inactive
Copy link

coderabbitai bot commented Nov 12, 2024

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

aleksandar-r and others added 8 commits November 21, 2024 17:34
chore: update tailwind config for ably-ui 14

chore: update circle ci config

chore: update jest config and snapshots

chore: update font-family to manrope remove next from global

chore: remove next font from all components

chore: add correct font weights

chore: add accordion font-weights and pass correct props

chore: add classes for font-sizes, remove inline styles

chore: update fonts in other product card

chore: update tests and snapshots

chore: fix classes, remove inline styles

upgrade ably-ui to 14.2.0

fix: properly export LeftSidebarProps

Fix the export syntax and rename index.js to index.ts for it to
propagate as well

fix: stop importing ably-ui styles everywhere

The styles are imported in the main stylesheet

chore: move importing the global stylesheet into Layout

fix: update load order of components to help CSS extraction

Subtle differences in the order in which components were imported
between the base-template and the pub-sub how-to caused errors for
mini-css-extract, consolidating the order removed the warnings

fix: drop @layer directives outside global styles

chore: Update footer status font

Fix: Indifinte lopp with tailwindcss

chore: bump ably-ui to 14.7.8

chore: add @tailwindcss/container-queries
@jamiehenson jamiehenson force-pushed the web-3426-css-changes-to-modernize-docs branch from c4f79ea to 819bdc6 Compare November 21, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants