-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WEB-3426] Modernize docs to latest Ably-UI Standards #2251
Draft
aralovelace
wants to merge
29
commits into
main
Choose a base branch
from
web-3426-css-changes-to-modernize-docs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the export syntax and rename index.js to index.ts for it to propagate as well
The styles are imported in the main stylesheet
Subtle differences in the order in which components were imported between the base-template and the pub-sub how-to caused errors for mini-css-extract, consolidating the order removed the warnings
…jects issue: Currently highlight styles not generated as its not added as safelist correctly in the tailwind configuration Co-Authored-By: Jamie Henson <1105768+jamiehenson@users.noreply.github.com>
Fix: The collapsable side nav is broken on this page FIx : tiny bit of collision between 2 inline code items
aralovelace
force-pushed
the
web-3426-css-changes-to-modernize-docs
branch
from
August 28, 2024 14:06
6fc72bd
to
406c9ee
Compare
aralovelace
changed the title
Web 3426 css changes to modernize docs
[WEB-3426] Modernize docs to latest Ably-UI Standards
Aug 28, 2024
right hand nav all appears super bold
aralovelace
force-pushed
the
web-3426-css-changes-to-modernize-docs
branch
from
August 29, 2024 10:42
72498ea
to
adca1a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A PR description indicating the purpose of the PR.
WEB-3426
Review
Instructions on how to review the PR.