-
Notifications
You must be signed in to change notification settings - Fork 44
Edu 2071 remove the general section of faqs #2824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Edu 2071 remove the general section of faqs #2824
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal). Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
@@ -0,0 +1,138 @@ | |||
--- | |||
title: Terms of Service |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it's correct to repeat these from the website, as we're just duplicating the content. If we think it's important to still reference them (maybe look at the relative popularity of the FAQ) then it should be an FAQ that links out to the website.
You could also test 'Ask Ably' and see what that currently picks up (I suspect it will just land them on the original terms of serivce, rather than going via the FAQs).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2e92099
to
d6400bb
Compare
This PR removes the general FAQ section and adds comprehensive documentation improvements across multiple areas of the platform:
How can I set up different environments in Ably?
Is there a limit to the length of the ClientId or Channel name?
How can I subscribe to messages using REST only SDKs?
CSP Rejection to internet-up.ably-realtime.com/is-the-internet-up.txt
Are the Message and Data Transfer Limits Enforced Separately?
Should I reduce the REST publish timeout?
Do you have a terms of service?
How can I alert a user to subscribe to a channel?
Redirects: General FAQ
FAQ: https://faqs.ably.com/general
Jira: EDU-2071