-
Notifications
You must be signed in to change notification settings - Fork 45
Add guide for building a scalable notifications center using Ably #2985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
166f898 to
627366b
Compare
GregHolmes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice guide! Just a few comments left.
|
|
||
| ### Best practices for offline handling | ||
|
|
||
| * **Enable history on inbox channels** to allow users to retrieve missed notifications |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do we do this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've extended the history section to talk about the persis all messages rule, do you think thats enough, or does this section need more detail? :)
|
|
||
| ## Next steps | ||
|
|
||
| * Read the [token authentication documentation](/docs/auth/token) for detailed auth implementation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need so many next steps? It'd be easy to get lost with all the links.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally, I have followed other guides like this one, but I could probably drop the pricing link and perhaps the integrations link?
627366b to
edc9f06
Compare
1908488 to
f57d1bf
Compare
Description
Add a guide that focuses on building a notifications center with Ably pubsub using Ably integrations to perform pre-processing on outbound notifications.
FF-164
TODO: There are a few diagrams/images that might be useful, I will ask design once we are happy with the content.
Checklist