Push: ensure all LocalDevice details are deleted on deregistration #710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@paddybyers do you want to go with the version of RSH2d in https://github.com/ably/docs/pull/694/files or here? |
tomczoink
force-pushed
the
push-spec-deregistration-update
branch
from
7dca2b4 to
73a555b
Compare
mattheworiordan
requested a deployment
to
ably-docs-staging-pr-710
…heck deviceToken validity on each launch; handle failures to obtain a deviceToken
tomczoink
force-pushed
the
push-spec-deregistration-update
branch
from
73a555b to
e470940
Compare
mattheworiordan
requested a deployment
to
ably-docs-staging-pr-710
|
Confirmed with @paddybyers this is the version we'd prefer for RSH2d. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also: check deviceToken validity on each launch; handle failures to obtain a deviceToken.
Partially fixes: https://github.com/ably/realtime/issues/2544