Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefer null over undefined consistently #141

Merged
merged 1 commit into from
Aug 29, 2023
Merged

Prefer null over undefined consistently #141

merged 1 commit into from
Aug 29, 2023

Conversation

dpiatek
Copy link
Contributor

@dpiatek dpiatek commented Aug 29, 2023

This makes get* methods consistent, always returning null instead undefined when no values are found.

ttypic
ttypic approved these changes Aug 29, 2023
View reviewed changes
Copy link
Collaborator

@ttypic ttypic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@dpiatek dpiatek mentioned this pull request Aug 29, 2023
Merged
@dpiatek dpiatek merged commit b991c71 into main Aug 29, 2023
5 checks passed
@dpiatek dpiatek deleted the consistent-null-return branch August 29, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttypic ttypic ttypic approved these changes

@artismarti artismarti Awaiting requested review from artismarti

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dpiatek @ttypic