feat: React hooks for Spaces #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: update callback options * fix: use `MemberEventsMap` for `MembersEvent` * feat: add `useCursors` hook (#210)
* feat: slide deck demo with hooks
* fix: `useLocations`,`useMembers` hook overload add `useCursors` variant without callback
Co-authored-by: Mark Hulbert <39801222+m-hulbert@users.noreply.github.com>
stmoreau
approved these changes
Oct 25, 2023
pchr-srf
reviewed
Nov 7, 2023
Comment on lines
+28
to
+29
| setStatus(null); | ||
| setMember(null); |
There was a problem hiding this comment.
FYI - this seems to cause missing rerenders - since React 16 setState(null) acts that way (but seems to be fixed again in React 18)
React 17: https://codesandbox.io/s/react-17-forked-dhx4f8
React 18: https://playcode.io/1655663
That was a fun afternoon 😬
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch contains all changes related to React hooks for Spaces release