Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chat: add chat connection CHA-CS* spec points #227

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Conversation

AndyTWF
Copy link
Contributor

@AndyTWF AndyTWF commented Nov 14, 2024

This change adds the spec points for chat connections, CHA-CS*.

umair-ably added a commit to ably/ably-chat-swift that referenced this pull request Nov 19, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
[1] - ably/specification#227

Note: CHA-CS5a3 has a typo in the spec. Omitted should be emitted. The typo has been fixed in the in-line spec comment in this commit.
umair-ably added a commit to ably/ably-chat-swift that referenced this pull request Nov 19, 2024
[1] - ably/specification#227

Note: CHA-CS5a3 has a typo in the spec. Omitted should be emitted. The typo has been fixed in the in-line spec comment in this commit.
umair-ably added a commit to ably/ably-chat-swift that referenced this pull request Nov 20, 2024
[1] - ably/specification#227

Note: CHA-CS5a3 has a typo in the spec. Omitted should be emitted. The typo has been fixed in the in-line spec comment in this commit.
umair-ably added a commit to ably/ably-chat-swift that referenced this pull request Nov 20, 2024
[1] - ably/specification#227

Note: CHA-CS5a3 has a typo in the spec. Omitted should be emitted. The typo has been fixed in the in-line spec comment in this commit.
umair-ably added a commit to ably/ably-chat-swift that referenced this pull request Nov 20, 2024
[1] - ably/specification#227

Note: CHA-CS5a3 has a typo in the spec. Omitted should be emitted. The typo has been fixed in the in-line spec comment in this commit.
umair-ably added a commit to ably/ably-chat-swift that referenced this pull request Nov 20, 2024
[1] - ably/specification#227

Note: CHA-CS5a3 has a typo in the spec. Omitted should be emitted. The typo has been fixed in the in-line spec comment in this commit.
umair-ably added a commit to ably/ably-chat-swift that referenced this pull request Nov 20, 2024
[1] - ably/specification#227

Note: CHA-CS5a3 has a typo in the spec. Omitted should be emitted. The typo has been fixed in the in-line spec comment in this commit.
@AndyTWF AndyTWF marked this pull request as ready for review November 20, 2024 15:06
@AndyTWF AndyTWF requested review from a team, owenpearson, JoaoDiasAbly and splindsay-92 and removed request for a team and JoaoDiasAbly November 20, 2024 15:06
umair-ably added a commit to ably/ably-chat-swift that referenced this pull request Nov 20, 2024
[1] - ably/specification#227

Note: CHA-CS5a3 has a typo in the spec. Omitted should be emitted. The typo has been fixed in the in-line spec comment in this commit.
umair-ably added a commit to ably/ably-chat-swift that referenced this pull request Nov 20, 2024
[1] - ably/specification#227

Note: CHA-CS5a3 has a typo in the spec. Omitted should be emitted. The typo has been fixed in the in-line spec comment in this commit.
umair-ably added a commit to ably/ably-chat-swift that referenced this pull request Nov 21, 2024
[1] - ably/specification#227

Note: CHA-CS5a3 has a typo in the spec. Omitted should be emitted. The typo has been fixed in the in-line spec comment in this commit.
umair-ably added a commit to ably/ably-chat-swift that referenced this pull request Nov 21, 2024
[1] - ably/specification#227

Note: CHA-CS5a3 has a typo in the spec. Omitted should be emitted. The typo has been fixed in the in-line spec comment in this commit.
Copy link
Contributor

@splindsay-92 splindsay-92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few small comments :)

This change adds the spec points for chat connections, CHA-CS*.
@AndyTWF AndyTWF merged commit ef59d66 into main Nov 22, 2024
2 checks passed
@AndyTWF AndyTWF deleted the chat-connection branch November 22, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants