This repository has been archived by the owner on Feb 14, 2023. It is now read-only.
Switch from tempdir to tempfile #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The test failure is coming from a dependency on |
|
Blocking on #111 |
Before this patch, multipart got into an impossible sitation with
it's dependencies. It errs with:
```
error: failed to select a version for `lazy_static`.
... required by package `multipart v0.15.4`
versions that meet the requirements `>= 1.0, < 1.2.0` are: 1.1.0, 1.0.2, 1.0.1, 1.0.0
all possible versions conflict with previously selected packages.
previously selected package `lazy_static v1.2.0`
... which is depended on by `ring v0.13.5`
... which is depended on by `cookie v0.11.0`
... which is depended on by `rocket_http v0.4.0`
... which is depended on by `rocket v0.4.0`
... which is depended on by `multipart v0.15.4
```
This is due to ring 0.13.3 bumping lazy_static to 1.2.0 to avoid
a [soundness bug](rust-lang-nursery/lazy-static.rs#117).
This patch fixes this problem by requiring at least rust 1.24.1.
In addition, I noticed that the feature sse4 was depending on
`twoway/pcmp`, but that has been [removed](bluss/twoway#8).
According to the tempdir repository, tempdir has been deprecated and replaced with tempfile: https://github.com/rust-lang-deprecated/tempdir#deprecation-note The current api publicly exposes the `tempdir::TempDir` type, so this patch is a breaking change to the public api, so I bumped the major version in the Cargo.toml file.
|
Sorry for the delay! I rebased this on master (and on #118) so it should pass tests again. |
Closed
abonander
reviewed
Jan 27, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the tempdir repository, tempdir has been deprecated
and replaced with tempfile:
https://github.com/rust-lang-deprecated/tempdir#deprecation-note
The current api publicly exposes the
tempdir::TempDirtype,so this patch is a breaking change to the public api, so I bumped
the major version in the Cargo.toml file.