Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: say this gem is unmaintained, transition tips #31

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cben
Copy link

@cben cben commented Apr 8, 2018

"We" know this is no longer necessary and therefore not maintained, but it's not obvious to somebody encountering this gem/repo first.

cc @zeari where did you encounter use of openshift_client? https://gitter.im/ManageIQ/manageiq/containers?at=5ac237dc1130fe3d3692f83a
[Unfortunately, requesting both openshift_client and a recent kubeclient does resolve in bundler, by digging out an ancient openshift_client 0.0.x version that had an open-ended >= dep on kubeclient. Don't think we can do anything about this now.]

@zeari
Copy link

zeari commented Apr 8, 2018

cc @zeari where did you encounter use of openshift_client?

I thought it was still needed to access OS only objects like routes and projects.

@cben
Copy link
Author

cben commented Apr 8, 2018

In that case, you're perfectly suited to review this PR 😉.
Is the README addition clear?

Copy link

@zeari zeari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@cben cben force-pushed the readme-transition-to-kubeclient branch from 0f442df to 55185af Compare December 27, 2018 10:08
@cben
Copy link
Author

cben commented Dec 27, 2018

Updated a bit.
@abonas ping, can you merge this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants