Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not assign None to codebase attributes #48 #49

Merged
merged 4 commits into from
Feb 23, 2023

Conversation

JonoYang
Copy link
Member

@JonoYang JonoYang commented Dec 1, 2022

Signed-off-by: Jono Yang jyang@nexb.com

Signed-off-by: Jono Yang <jyang@nexb.com>
@JonoYang JonoYang requested a review from pombredanne December 1, 2022 00:16
Signed-off-by: Jono Yang <jyang@nexb.com>
@JonoYang JonoYang force-pushed the 48-correctly-assign-codebase-attributes branch 2 times, most recently from 94707c6 to b9bdf5f Compare February 4, 2023 01:35
Signed-off-by: Jono Yang <jyang@nexb.com>
@JonoYang JonoYang force-pushed the 48-correctly-assign-codebase-attributes branch from b9bdf5f to 59c9c17 Compare February 4, 2023 01:36
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with only one small nit to fix.
Thanks!

setup.cfg Outdated Show resolved Hide resolved
Signed-off-by: Jono Yang <jyang@nexb.com>
@JonoYang JonoYang merged commit a31199f into main Feb 23, 2023
@pombredanne pombredanne deleted the 48-correctly-assign-codebase-attributes branch February 24, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants