Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework how parent/ancestor pom information is collected and used during on-demand maven mining #160

Open
JonoYang opened this issue Aug 7, 2023 · 0 comments

Comments

@JonoYang
Copy link
Member

JonoYang commented Aug 7, 2023

I was running a script to fetch license information for maven packages without a declared license expression. This script uses code from minecode/visitors/maven.py. However, my script appeared to not update the declared license expression for those packages. I debugged a bit and found that we are running into the situation where the parent poms for a maven package have a different namespace than the the package we're looking at, and (in certain cases) is preventing us from getting a license expression.

We should look into relaxing this constraint: https://github.com/nexB/purldb/blob/main/minecode/visitors/maven.py#L258

@pombredanne suggests that we should ignore certain parent poms, like https://github.com/sonatype/oss-parents . Another idea would be to save maven packages that are parent poms to the db and add those to the package sets for packages that get its license from the parent.

JonoYang added a commit that referenced this issue Aug 8, 2023
Signed-off-by: Jono Yang <jyang@nexb.com>
JonoYang added a commit that referenced this issue Aug 8, 2023
Signed-off-by: Jono Yang <jyang@nexb.com>
JonoYang added a commit that referenced this issue Aug 9, 2023
Signed-off-by: Jono Yang <jyang@nexb.com>
JonoYang added a commit that referenced this issue Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant