Add support for custom maven repository URLs #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AyanSinhaMahapatra
force-pushed
the
support-custom-repo-url
branch
from
9ea92e3
to
74c225f
Compare
Adds support for getting packages from custom repository URLs, in the case of maven packages. Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
AyanSinhaMahapatra
force-pushed
the
support-custom-repo-url
branch
from
74c225f
to
36a5e9e
Compare
JonoYang
requested changes
Aug 8, 2023
There was a problem hiding this comment.
@AyanSinhaMahapatra Looks good! Can you create another test like https://github.com/nexB/purldb/blob/main/minecode/tests/test_maven.py#L718, but you pass in a purl with a repository_url qualifier and check to see if the created package has the right URLs?
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
AyanSinhaMahapatra
force-pushed
the
support-custom-repo-url
branch
from
6e727ca
to
3b2493b
Compare
|
@JonoYang I've added a test for this, please review if this works. Thanks! |
JonoYang
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for getting packages from custom repository URLs, in the case of maven packages.
Example purl with
repository_urlas a qualifier:pkg:maven/org.eclipse.core/runtime@20070801?repository_url=https://packages.atlassian.com/mvn/maven-atlassian-external/