Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore version-less purl when version range is missing #176

Merged
merged 2 commits into from
Aug 29, 2023

Conversation

keshav-space
Copy link
Member

We should not attempt to index version-less purl where vers range is missing.

- Do not attempt to index version-less purl where vers range is missing

Signed-off-by: Keshav Priyadarshi <git@keshav.space>
Copy link
Member

@JonoYang JonoYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@keshav-space I made some suggestions to code logic.

packagedb/api.py Show resolved Hide resolved
packagedb/api.py Outdated Show resolved Hide resolved
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
@keshav-space
Copy link
Member Author

@JonoYang Thanks!
Reviews addressed.

@JonoYang
Copy link
Member

LGTM, thanks!

@JonoYang JonoYang merged commit 3b820dd into main Aug 29, 2023
8 checks passed
@keshav-space keshav-space deleted the ignore-versionless-purl-without-vers branch August 29, 2023 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants