Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose new scan queue to many workers #49 #290

Merged
merged 32 commits into from
Mar 19, 2024
Merged

Conversation

pombredanne
Copy link
Member

This pull request adds a new endpoint that exposes the scanning queue pending requests.
The design is exposed in #236
The client side is in aboutcode-org/scancode.io#1078
The original issue that started this work is at #49

@pombredanne pombredanne changed the title Scan queue and process update #49 Expose new scan queue to many workers #49 Feb 15, 2024
@JonoYang JonoYang force-pushed the 49-scan-queue-update branch 3 times, most recently from f225076 to 0ed31d6 Compare February 22, 2024 00:11
Signed-off-by: Jono Yang <jyang@nexb.com>
Signed-off-by: Jono Yang <jyang@nexb.com>
Signed-off-by: Jono Yang <jyang@nexb.com>
Signed-off-by: Jono Yang <jyang@nexb.com>
Signed-off-by: Jono Yang <jyang@nexb.com>
Signed-off-by: Jono Yang <jyang@nexb.com>
    * Create test for ScannableURI API

Signed-off-by: Jono Yang <jyang@nexb.com>
Signed-off-by: Jono Yang <jyang@nexb.com>
Signed-off-by: Jono Yang <jyang@nexb.com>
Signed-off-by: Jono Yang <jyang@nexb.com>
    * Update tests

Signed-off-by: Jono Yang <jyang@nexb.com>
Signed-off-by: Jono Yang <jyang@nexb.com>
Signed-off-by: Jono Yang <jyang@nexb.com>
    * Guard scan_queue API endpoint

Signed-off-by: Jono Yang <jyang@nexb.com>
Signed-off-by: Jono Yang <jyang@nexb.com>
Signed-off-by: Jono Yang <jyang@nexb.com>
Signed-off-by: Jono Yang <jyang@nexb.com>
Signed-off-by: Jono Yang <jyang@nexb.com>
Signed-off-by: Jono Yang <jyang@nexb.com>
    * Do not overwrite spdx license fields as these are generated
    * set Package fields to be nullable

Signed-off-by: Jono Yang <jyang@nexb.com>
Signed-off-by: Jono Yang <jyang@nexb.com>
    * Test to see if package data can be updated from indexing

Signed-off-by: Jono Yang <jyang@nexb.com>
Signed-off-by: Jono Yang <jyang@nexb.com>
    * Add tests for validate_uuid
    * Test for missing scan_status in update_status

Signed-off-by: Jono Yang <jyang@nexb.com>
Signed-off-by: Jono Yang <jyang@nexb.com>
Signed-off-by: Jono Yang <jyang@nexb.com>
Signed-off-by: Jono Yang <jyang@nexb.com>
Signed-off-by: Jono Yang <jyang@nexb.com>
Signed-off-by: Jono Yang <jyang@nexb.com>
    * Update quotes

Signed-off-by: Jono Yang <jyang@nexb.com>
Copy link
Member

@keshav-space keshav-space left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JonoYang LGTM

minecode/visitors/npm.py Outdated Show resolved Hide resolved
Signed-off-by: Jono Yang <jyang@nexb.com>
Copy link
Contributor

@TG1999 TG1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JonoYang JonoYang merged commit b2c8013 into main Mar 19, 2024
8 checks passed
@JonoYang JonoYang deleted the 49-scan-queue-update branch March 19, 2024 17:30
@JonoYang JonoYang mentioned this pull request Mar 28, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants