Support indexing of directory listed and GNU packages #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
keshav-space
force-pushed
the
support-indexing-of-dir-listed-packages
branch
3 times, most recently
from
77d9faa
to
dedf971
Compare
…ir-listed-packages
keshav-space
force-pushed
the
support-indexing-of-dir-listed-packages
branch
from
dedf971
to
5d6e1d7
Compare
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
JonoYang
requested changes
Mar 13, 2024
There was a problem hiding this comment.
@keshav-space Looks good, I just had some questions in test_gnu.py
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
|
@keshav-space I think the PR looks alright. @pombredanne Do you have any thoughts on this? |
|
IMHO we should switch to use Azure pipelines instead |
|
but this is another thing entirely. |
pombredanne
approved these changes
Mar 14, 2024
| logger.error(error) | ||
| return error | ||
|
|
||
| package_data = packages[0].to_dict() |
There was a problem hiding this comment.
can there be more than 1?
There was a problem hiding this comment.
For a versioned PURL it cannot be more than one.
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
This was referenced Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR adds support for indexing these PURLs