Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update data structure and create new set of mocked tests #348

Merged
merged 4 commits into from
Mar 22, 2024
Merged

Update data structure and create new set of mocked tests #348

merged 4 commits into from
Mar 22, 2024

Conversation

johnmhoran
Copy link
Contributor

Reference: #320

@johnmhoran
Update data structure, refector live fetch tests and create new set o…
434572c 
…f mocked tests #320

Reference: #320

Signed-off-by: John M. Horan <johnmhoran@gmail.com>
@johnmhoran
Merge branch 'main' into 320-mock-fetching-in-purldb-toolkit-tests #320
85d7f89 
Reference: #320

Signed-off-by: John M. Horan <johnmhoran@gmail.com>
@johnmhoran
Update live-fetch and mocked tests #320
0e4bf89 
Reference: #320

Signed-off-by: John M. Horan <johnmhoran@gmail.com>
@johnmhoran
Copy link
Contributor Author

@JonoYang @keshav-space Please take a look at my PR when you have the chance. I've updated the live-fetch and the mocked tests and set the live-fetch test file (test_purlcli.py) to be skipped by default.

JonoYang
JonoYang requested changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@JonoYang JonoYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@johnmhoran I left some comments for you

purldb-toolkit/tests/test_purlcli.py Outdated Show resolved Hide resolved
purldb-toolkit/tests/test_purlcli_mock.py Outdated Show resolved Hide resolved
purldb-toolkit/tests/test_purlcli_mock.py Outdated Show resolved Hide resolved
purldb-toolkit/tests/test_purlcli.py Show resolved Hide resolved
@johnmhoran
Add context manager, extract repeated code block to new function #320
fa9c88c 
Reference: #320

Signed-off-by: John M. Horan <johnmhoran@gmail.com>
JonoYang
JonoYang approved these changes Mar 22, 2024
View reviewed changes
Copy link
Contributor

@JonoYang JonoYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@johnmhoran LGTM!

@JonoYang JonoYang merged commit a110692 into main Mar 22, 2024
8 checks passed
@JonoYang JonoYang deleted the 320-mock-fetching-in-purldb-toolkit-tests branch March 22, 2024 19:22
@johnmhoran johnmhoran mentioned this pull request Mar 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonoYang JonoYang JonoYang approved these changes

@keshav-space keshav-space Awaiting requested review from keshav-space

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnmhoran @JonoYang