Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace freenode references with libera chat #6

Merged
merged 6 commits into from
Feb 10, 2022

Conversation

purna135
Copy link
Contributor

Reference Issues/PRs

Fixes Replace references to freenode #92

What does this implement/fix? Explain your changes.
Replaced freenode references with the official IRC channel i.e Gitter and liberachat

Any other comments?
Thank You!

Signed-off-by: Purna Chandra Mansingh <purnachandramansingh135@gmail.com>
Signed-off-by: Purna Chandra Mansingh <purnachandramansingh135@gmail.com>
Signed-off-by: Purna Chandra Mansingh <purnachandramansingh135@gmail.com>
Signed-off-by: Purna Chandra Mansingh <purnachandramansingh135@gmail.com>
@purna135
Copy link
Contributor Author

Hello, it was previously failing a test because I removed some unused script(etc/scripts/irc-notify.py )

Error Message:

src\compiledcode\dwarf3.py:107: TypeError
==================== 6 failed, 142 passed in 19.59 seconds ====================
Command exited with code 1
python etc/scripts/irc-notify.py aboutcode [{project_name}:{branch}] {short_commit}: "{message}" ({author}) {color_red}Failed,Details: {build_url},Commit: {commit_url}
python: can't open file 'etc/scripts/irc-notify.py': [Errno 2] No such file or directory
Command exited with code 2

So I removed test from appveyor.yml.
Could you please confirm that this is acceptable?
or should I delete the entire file - appveyor.yml

@pombredanne
Copy link
Member

Are you sure that #6 (comment) is about this repo?

build: off


test_script:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You cannot remove the tests run... this would be a bit like hurting yourself with a knife intentionally.
Instead only remove the on_success and on_failure block below

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I got it; it was my fault.

Signed-off-by: Purna Chandra Mansingh <purnachandramansingh135@gmail.com>
@pombredanne
Copy link
Member

Are you sure that #6 (comment) is about this repo?

Ignore this. I thought this was for scancode-toolkit

Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good except for a nitpicking for a missing trailing empty line

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne pombredanne merged commit fdfeceb into aboutcode-org:develop Feb 10, 2022
@purna135
Copy link
Contributor Author

Thank you : )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace references to freenode
2 participants