-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace freenode references with libera chat #6
Conversation
Signed-off-by: Purna Chandra Mansingh <purnachandramansingh135@gmail.com>
Signed-off-by: Purna Chandra Mansingh <purnachandramansingh135@gmail.com>
Signed-off-by: Purna Chandra Mansingh <purnachandramansingh135@gmail.com>
Signed-off-by: Purna Chandra Mansingh <purnachandramansingh135@gmail.com>
Hello, it was previously failing a test because I removed some unused script(etc/scripts/irc-notify.py ) Error Message:
So I removed test from appveyor.yml. |
Are you sure that #6 (comment) is about this repo? |
build: off | ||
|
||
|
||
test_script: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You cannot remove the tests run... this would be a bit like hurting yourself with a knife intentionally.
Instead only remove the on_success and on_failure block below
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, I got it; it was my fault.
Signed-off-by: Purna Chandra Mansingh <purnachandramansingh135@gmail.com>
dbdb3e9
to
6ad6b09
Compare
Ignore this. I thought this was for scancode-toolkit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good except for a nitpicking for a missing trailing empty line
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Thank you : ) |
Reference Issues/PRs
Fixes Replace references to freenode #92
What does this implement/fix? Explain your changes.
Replaced freenode references with the official IRC channel i.e Gitter and liberachat
Any other comments?
Thank You!