Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

progress should be based on 100% scale #10

Closed
pombredanne opened this issue Jul 5, 2015 · 2 comments
Closed

progress should be based on 100% scale #10

pombredanne opened this issue Jul 5, 2015 · 2 comments

Comments

@pombredanne
Copy link
Member

reported by @chinyeungli

Scanning files...
  [------------------------------------]  1

I thought the above is the progress bar based on percentage. But then I realize it's number of file counts.

I think 100% scale make more scenes as not many users care about how many files have been processed, but how much left to be completed.

@pombredanne
Copy link
Member Author

To compute a percentage we need to know ahead of time the number of items that will be computed.

This means walking the file system first to count files and weight that possibly based on the size of each file.

This is not a big deal, but would possibly slow down a bit every scan. Another thing could be to make the progress being displayed based on an option rather than by default (for instance rsync displays progress on demand only).

@pombredanne
Copy link
Member Author

I am closing as wontfix because it is either never possible to exactly know a correct percentage or getting a reasonable percentage is likely prohibitively expensive as this requires a whole pre-processing of a scanned tree.

Please reopen if you feel strongly about this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant