Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Archives of scancode 1.4.0 don't run. #142

Closed
rrjohnston opened this issue Dec 1, 2015 · 4 comments
Closed

Archives of scancode 1.4.0 don't run. #142

rrjohnston opened this issue Dec 1, 2015 · 4 comments
Assignees

Comments

@rrjohnston
Copy link

After unpacking either the bz2 or zip file onto 3.13.0-32-generic #57~precise1-Ubuntu machine, trying to run the utility on a source directory (after running './scancode --help') always results in the following error (this particular example was scanning the scancode-toolkit-1.4.0/src directory):

$: ./scancode --format html src src.html
Scanning files...
[------------------------------------] 1 Scanning: textcode
Scanning done.
Traceback (most recent call last):
File "//scancode-toolkit-1.4.0/bin/scancode", line 9, in
load_entry_point('scancode-toolkit==1.4.0', 'console_scripts', 'scancode')()
File "//scancode-toolkit-1.4.0/local/lib/python2.7/site-packages/click/core.py", line 664, in call
return self.main(_args, *_kwargs)
File "//scancode-toolkit-1.4.0/src/scancode/utils.py", line 61, in main
standalone_mode=standalone_mode, *_extra)
File "//scancode-toolkit-1.4.0/local/lib/python2.7/site-packages/click/core.py", line 644, in main
rv = self.invoke(ctx)
File "//scancode-toolkit-1.4.0/local/lib/python2.7/site-packages/click/core.py", line 837, in invoke
return ctx.invoke(self.callback, *_ctx.params)
File "//scancode-toolkit-1.4.0/local/lib/python2.7/site-packages/click/core.py", line 464, in invoke
return callback(_args, *_kwargs)
File "//scancode-toolkit-1.4.0/src/scancode/cli.py", line 244, in scancode
results = scan(input, copyright, license, package, info, verbose, quiet)
File "//scancode-toolkit-1.4.0/src/scancode/cli.py", line 312, in scan
scan_result.update(scan_one(res, scanners))
File "//scancode-toolkit-1.4.0/src/scancode/cli.py", line 329, in scan_one
scan = scan_func(input_file)
File "//scancode-toolkit-1.4.0/src/scancode/api.py", line 137, in get_package_infos
from packagedcode.recognize import recognize_packaged_archives
ImportError: No module named packagedcode.recognize

@jdaguil
Copy link
Contributor

jdaguil commented Dec 1, 2015

@rrjohnston I've reproduced the error from the release archives as well. Although the issue is not present when cloning from master or downloading the archive directly from the master branch.

@pombredanne pombredanne self-assigned this Dec 3, 2015
@pombredanne
Copy link
Member

I found the culprit: https://github.com/nexB/scancode-toolkit/blob/9be433a8e6f1741aa75de64fe00d0fdc458625c5/etc/release/MANIFEST.in.release#L8
This is the release script. Let me re-run and push a new .release

@pombredanne
Copy link
Member

I will also be adding a release test (either a plain script or as part of the CI configs)

pombredanne added a commit that referenced this issue Dec 3, 2015
 * also fixed #129 including the samples in the release builds.
 * improved the release scripts and CI to include test of built
   archive
 * added release script run to the Ci test suite
 * added packagedcode to CI test suites (it was missing)
@pombredanne
Copy link
Member

This is fixed in the new release 1.4.2. And from now on, sanity checks are included in the release script.
@rrjohnston Thank you for the report!

pombredanne added a commit that referenced this issue Dec 7, 2015
pombredanne added a commit that referenced this issue Dec 7, 2015
… also fixed #129 including the samples in the release builds.  * improved the release scripts and CI to include test of built    archive  * added release script run to the Ci test suite  * added packagedcode to CI test suites (it was missing)  "

This reverts commit 8c730e0.
pombredanne added a commit that referenced this issue Dec 7, 2015
 * also fixed #129 including the samples in the release builds.
 * improved the release scripts and CI to include test of built
   archive
 * added release script run to the Ci test suite
 * added packagedcode to CI test suites (it was missing)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants