Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address packages without a name in order to generate a valid purl #1514

Open
pombredanne opened this issue Apr 8, 2019 · 2 comments
Open

Comments

@pombredanne
Copy link
Member

Description

Some package manifest may be missing some esssential identifying info such as a name or version.
This could be the case when these are dynamically generated at build time or when the package type allows this (such as bower, npm or composer private packages) . We should still capture this and not balk as there can be a lot of useful data beyond this

@steven-esser
Copy link
Contributor

@pombredanne Did we determine that packages without a name should NOT be allowed?

@pombredanne
Copy link
Member Author

pombredanne commented Aug 20, 2019

@MaJuRG I am split on this. For now they are allowed. BUT they are super rare.

On the one hand, once a package has no name, its manifest becomes close to a mere build_script than a proper package_manifest as discussed in #1237.

On the other hand they may still contain valuable license and origin data.

So I may be inclined to allow an empty name and to add an explicit private flag attribute when a package has no name?

@pombredanne pombredanne self-assigned this Sep 26, 2019
@DennisClark DennisClark changed the title Accept packages without a name Address packages without a name in order to generate a valid purl Aug 18, 2020
AyanSinhaMahapatra added a commit that referenced this issue May 30, 2024
Reference: #3102
Reference: #1514
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
AyanSinhaMahapatra added a commit that referenced this issue May 30, 2024
Reference: #3102
Reference: #1514
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
AyanSinhaMahapatra added a commit that referenced this issue Jun 4, 2024
Reference: #3102
Reference: #1514
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants