Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add back file-level package manifest #1728

Closed
pombredanne opened this issue Sep 13, 2019 · 1 comment
Closed

Add back file-level package manifest #1728

pombredanne opened this issue Sep 13, 2019 · 1 comment
Labels
must have new feature package scan
Milestone
v3.2

Comments

@pombredanne
Copy link
Member

Description

Since #1212 and 4605700 (Remove package_manifest attribute for packages ) package manifest are moved to the root package location away from their manifest files. This creates all kind of weirdness such as having a manifest file without any info.

I think we should instead have this behavior:

  1. a package_manifest attribute at the file-level (and BTW for non-package thing such as build scripts, Makefile, bazel, BUCK, Gradle, etc, have that data under a build_script attribute.
  2. this attribute should stay there and should be COPIED and not MOVED to its root package location if any
pombredanne added a commit that referenced this issue Sep 17, 2019
@pombredanne
Add back package_manifests #1728
81db9c6 
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne pombredanne mentioned this issue Oct 1, 2019
Closed
@pombredanne
Copy link
Member Author

This is tracked instead in #1237 (comment)

pombredanne added a commit that referenced this issue Oct 16, 2019
@pombredanne
Merge latest develop in 1728-package-manifests #1728
ec7ce1b 
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
JonoYang added a commit that referenced this issue Oct 17, 2019
@JonoYang
Merge pull request #1730 from nexB/1728-package-manifests
f53e886 
Add back package_manifests #1728
viragumathe5 pushed a commit to viragumathe5/scancode-toolkit that referenced this issue Mar 13, 2020
@pombredanne @viragumathe5
Add back package_manifests aboutcode-org#1728
40f0c9d 
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
must have new feature package scan
Projects
None yet
Milestone
v3.2
Development

No branches or pull requests
1 participant
@pombredanne