Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rule "bsd-new_or_gpl-2.0_12.RULE" matches even though GPL alternative block isn't there #1795

Closed
MartinPetkov opened this issue Oct 25, 2019 · 1 comment
Closed

Rule "bsd-new_or_gpl-2.0_12.RULE" matches even though GPL alternative block isn't there #1795

MartinPetkov opened this issue Oct 25, 2019 · 1 comment
Labels
bug license scan

Comments

@MartinPetkov
Copy link

MartinPetkov commented Oct 25, 2019 •
edited
Loading

Description

It's not clear to me why this block matches the bsd-or-gpl rule, since it's missing the the "Alternatively, this software may be distributed under the terms of the GNU General Public License ("GPL") version 2 as published by the Free Software Foundation." blurb. The only difference I can see is that it says "JANINO" instead of "the copyright holders".

Steps to reproduce:

$ git clone https://github.com/apache/beam
$ cd beam && git checkout 4fa1501b377e70df0971ec4a4b8f585fd8f34a6c
$ scancode --verbose --license -n 12 --json-pp ./results.json --only-findings --info --strip-root --license-text ./LICENSE
$ cat ./results.json

System configuration

For bug reports, it really helps us to know:

  • What OS are you running on? (Windows/MacOS/Linux)
    Linux
  • What version of scancode-toolkit was used to generate the scan file?
    ScanCode version 3.1.1.post168.648281097
  • What installation method was used to install/run scancode? (pip/source download/other)
    Pip
pombredanne added a commit that referenced this issue Oct 30, 2019
@pombredanne
Do not detect spurrious dual licenses #1795
27a3370 
Some larger coverage is needed in these cases.

Reported-by: Martin Petkov <martin.p.petkov@gmail.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
pombredanne added a commit that referenced this issue Oct 30, 2019
@pombredanne
Add new BSD license rules #1795
96e7216 
Found while scanning Apache Beam license notice

Reported-by: Martin Petkov <martin.p.petkov@gmail.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
viragumathe5 pushed a commit to viragumathe5/scancode-toolkit that referenced this issue Mar 13, 2020
@pombredanne @viragumathe5
Do not detect spurrious dual licenses aboutcode-org#1795
350b2ec 
Some larger coverage is needed in these cases.

Reported-by: Martin Petkov <martin.p.petkov@gmail.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
viragumathe5 pushed a commit to viragumathe5/scancode-toolkit that referenced this issue Mar 13, 2020
@pombredanne @viragumathe5
Add new BSD license rules aboutcode-org#1795
58bc53f 
Found while scanning Apache Beam license notice

Reported-by: Martin Petkov <martin.p.petkov@gmail.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
pombredanne added a commit that referenced this issue Sep 7, 2020
@pombredanne
Improve license detection of Apache BEAM #1795
4268c1b 
Reported-by: Martin Petkov @MartinPetkov
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne
Copy link
Member

All fixed and merged in develop. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug license scan
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pombredanne @MartinPetkov