Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenVPN 2.3.4: GPL-1.0-or-later false positive #1919

Closed
armijnhemel opened this issue Feb 17, 2020 · 1 comment
Closed

OpenVPN 2.3.4: GPL-1.0-or-later false positive #1919

armijnhemel opened this issue Feb 17, 2020 · 1 comment
Labels

Comments

@armijnhemel
Copy link
Contributor

Description

openvpn-2.3.4/contrib/pull-resolv-conf/client.up

is recognized as GPL-1.0-or-later but it is not.

How To Reproduce

Tell us how to reproduce the issue.

System configuration

For bug reports, it really helps us to know:

ScanCode version 3.1.1.post337.16377111fe

@pombredanne
Copy link
Member

Fixed and merged in develop

pombredanne pushed a commit that referenced this issue Sep 8, 2022
Web accessibility is important. Unfortunately currently many pygments
styles have rules with poor contrasts. This commit introduces a test
case that fails if the minimum contrast of a style gets worse, e.g:

E  AssertionError: contrast degradation for style 'borland'
E    The following rules have a contrast lower than the required 2.9:
E
E    * 1.90 Token.Text.Whitespace
E    * 2.80 Token.Generic.Heading
E    * 2.30 Token.Generic.Subheading
E
E  assert not 1.9 < 2.9

This is accomplished by storing the current minimum contrasts in
./tests/contrast/min_contrasts.json.

When you improve a minimum contrast the test fails with:

E  AssertionError: congrats, you improved a contrast! please run ./scripts/update_contrasts.py
E  assert not 1.9 > 0.9

Running the script as instructed updates the JSON file, making the test pass.

New styles are required to meet the WCAG AA contrast minimum of 4.5.

First commit to address #1718.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants