-
-
Notifications
You must be signed in to change notification settings - Fork 567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
other-permissive includes references to now-defunct visualidiot.com #1999
Comments
@sutula good catch! And thank you for this. Your suggestion to add a new license for that makes the most sense to me, even if this a legacy license of sorts there are still enough examples of this https://github.com/search?q=%22persons%2C+or+any+similar+actions+percolating+the+given+%22&type=Code This would be best qualified as some kind of proprietary license e.g. using the "Proprietary Free" category. We can always change the category afterwards too, but IMHO the combo of a license key of So in recap we could:
A patch would be great and I am on hand to help as needed. @DennisClark this is the problematic text FWIW, which makes me cringe rather than smile.
|
Per discussion in aboutcode-org#1999, the now-defunct visualidiot.com license should receive scrutiny by those who might be using code containing such a license. It is currently mis-categorized as other-permissive, inviting users to overlook the license. This commit moves the license to it's own license type, visual-idiot. Signed-off-by: Bryan Sutula <sutula@redhat.com>
Per discussion in aboutcode-org#1999, rules/visual-idiot_1.* duplicates the license text that was placed in licenses/ and is not necessary. Signed-off-by: Bryan Sutula sutula@redhat.com
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
These are extra rules for a few common notices, tags and references such that we cast a wider net on this license. Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Move visualidiot license to its own type #1999 Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Description
#960 added three rules related to the visualidiot license. Since that time, the referenced website has changed such that the license isn't visible any more. It may be that the domain has changed hands or that the original author uses these references for publicity or click-bait. In any case, I would take issue with continuing to characterize the following three rules as "permissive":
Note that the rule source code includes a web archive URL which still lists the original contents of the referenced URL.
If this text still exists in code, then it is still worthwhile to detect it. Rather than simply removing these rules, can we move them to a license type that reflects that they are not necessarily benign permissive texts, but that would require some amount of legal scrutiny before code licensed under these texts could be utilized, if it could be used at all?
How To Reproduce
This issue relates to how certain license texts are characterized/categorized. The issue isn't so much reproduced as seen by inspection of the underlying license rules. The following source files are involved:
System configuration
This issue is independent of system configuration.
Offer of Help
I'd be happy to submit a patch for this change, but would like to hear suggestions for a new license category home for the visualidiot license. If there seems to be an existing category that would fit, let's re-use it. Otherwise, I suggest a new license type for this one.
The text was updated successfully, but these errors were encountered: