Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test missing, only] Missing copyright extraction from notice.txt file #2140

Open
FlorianSW opened this issue Jul 29, 2020 · 1 comment
Open
Labels

Comments

@FlorianSW
Copy link

Description

ClearlyDefined used ScanBot to extract license information from org.springframework.spring-beans in version 5.2.6.RELEASE (see https://clearlydefined.io/definitions/maven/mavencentral/org.springframework/spring-beans/5.2.6.RELEASE/5.2.6.RELEASE).

However, the library contains a notice.txt file in META-INF with a copyright notice in it. Unfortunately, only the copyright from the license file were extracted, while ignoring the one from the notice.txt.

How To Reproduce

Run scanbot on the mentioned version of spring-beans.

Notes

This issue seems to be magically fixed in the latest dev version of scanbot, however, @pombredanne (hope it's the correct one :P) asked me in discord to create an issue as a reminder to add a test for that case, in order to ensure that the issue does not occur again :)

@FlorianSW FlorianSW added the bug label Jul 29, 2020
pombredanne added a commit that referenced this issue Jul 29, 2020
This issued existed on 3.0.2 and was fixed with commit:
7ca5115

Reported-by: @FlorianSW
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne
Copy link
Member

@FlorianSW Thanks! I pushed a branch with the test.

pombredanne added a commit that referenced this issue Jul 29, 2020
Add test for copyright with year range #2140
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants