-
-
Notifications
You must be signed in to change notification settings - Fork 562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Design the new user experience for primary/declared data summaries in SCTK #2842
Comments
Here is consensus from some chat and discussions: deprecate and remove in the version after next all these options
The new "primary", may be reusing code from summary-key-files is tracked in #2065 and will be always ON in the default JSON/YAML output. The new license clarity scoring is tracked in #2861 and will be always ON in the default JSON/YAML output. So the key is clarity and primary becomes standard, non opt-in, always on options |
And the |
Signed-off-by: Jono Yang <jyang@nexb.com>
* Refactor check_for_license_ambiguity to return a primary license expression Signed-off-by: Jono Yang <jyang@nexb.com>
Signed-off-by: Jono Yang <jyang@nexb.com>
* Refactor check_for_license_ambiguity to return a primary license expression Signed-off-by: Jono Yang <jyang@nexb.com>
Signed-off-by: Jono Yang <jyang@nexb.com>
Signed-off-by: Jono Yang <jyang@nexb.com>
* Refactor check_for_license_ambiguity to return a primary license expression Signed-off-by: Jono Yang <jyang@nexb.com>
Signed-off-by: Jono Yang <jyang@nexb.com>
Otherwise the variable may not exist and may not be provided to another plugin if not True. Reference: #2842 Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Reference: #2842 Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Reference: #2842 Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Using option dependencies is cleaner than chaning how an option is enabled. Reference: #2842 Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Reference: #2842 Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
We now have a new |
Reference: #2842 Signed-off-by: Jono Yang <jyang@nexb.com>
Reference: #2842 Signed-off-by: Jono Yang <jyang@nexb.com>
* Set summary2 to be new summary plugin * Update tests Signed-off-by: Jono Yang <jyang@nexb.com>
Reference: #2842 Signed-off-by: Jono Yang <jyang@nexb.com>
* Remove declared values from license_expressions, holders, programming_language summary lists and then call those lists `other_license_expressions, `other_holders`, and `other_programming_languages`, respectivly. Reference: #2842 Signed-off-by: Jono Yang <jyang@nexb.com>
* Move old summarizer code to legacy_summarizer.py Reference: #2842 Signed-off-by: Jono Yang <jyang@nexb.com>
* Remove summarizer2.py Reference: #2842 Signed-off-by: Jono Yang <jyang@nexb.com>
* Update summarizer test cases using codebases of real code Reference: #2842 Signed-off-by: Jono Yang <jyang@nexb.com>
Reference: #2842 Signed-off-by: Jono Yang <jyang@nexb.com>
Reference: #2842 Signed-off-by: Jono Yang <jyang@nexb.com>
Reference: #2842 Signed-off-by: Jono Yang <jyang@nexb.com>
* Add new simple test for scan summarizer * Rename previous simple test to package Reference: #2842 Signed-off-by: Jono Yang <jyang@nexb.com>
* Add new summarizer tests for license ambiguity, conflicting license categories * Rename previous simple test to package * Remove full and copyright test Reference: #2842 Signed-off-by: Jono Yang <jyang@nexb.com>
Reference: #2842 Signed-off-by: Jono Yang <jyang@nexb.com>
Reference: #2842 Signed-off-by: Jono Yang <jyang@nexb.com>
Reference: #2842 Signed-off-by: Jono Yang <jyang@nexb.com>
Reference: #2842 Signed-off-by: Jono Yang <jyang@nexb.com>
* Combine all detected origin info from multiple package data and use the resulting values in the summary * Create new test for multiple package data summarization Reference: #2842 Signed-off-by: Jono Yang <jyang@nexb.com>
The latest approach is going to keep the old --summary and rename it as --tallies and the new summary is replacing it and --consolidate will be deprecated. |
* Remove redundant code in summarizer.py Reference: #2842 Signed-off-by: Jono Yang <jyang@nexb.com>
* Remove all references to summarization in tallies tests Reference: #2842 Signed-off-by: Jono Yang <jyang@nexb.com>
* Remove all references to summarization in tallies tests Reference: #2842 Signed-off-by: Jono Yang <jyang@nexb.com>
* Remove copyright_summary.py * Update summarizer help text Reference: #2842 Signed-off-by: Jono Yang <jyang@nexb.com>
Reference: #2842 Signed-off-by: Jono Yang <jyang@nexb.com>
Reference: #2842 Signed-off-by: Jono Yang <jyang@nexb.com>
* This allows us to more effectivly remove declared holders from the other holders list * Update holders summarization tests Reference: #2842 Signed-off-by: Jono Yang <jyang@nexb.com>
Reference: #2842 Signed-off-by: Jono Yang <jyang@nexb.com>
* Do not rename summaries to tallies Reference: #2842 Signed-off-by: Jono Yang <jyang@nexb.com>
* Do not rename summaries to tallies Reference: #2842 Signed-off-by: Jono Yang <jyang@nexb.com>
* Do not rename summaries to tallies Reference: #2842 Signed-off-by: Jono Yang <jyang@nexb.com>
Reference: #2842 Signed-off-by: Jono Yang <jyang@nexb.com>
Reference: #2842 Signed-off-by: Jono Yang <jyang@nexb.com>
We have updated the summary plugin with the new fields and scoring critera and merged the code in #2914 |
Btw, we have not made the options default (--classify/--summary/--license-clarity-score), yet. This is for the next release tentatively? |
We have many related options and we want to design a new, better approach to get primary, declared licensing and package data. What would it be?
This is the current set of options:
The text was updated successfully, but these errors were encountered: