Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect purl type for cocoapods #3081

Closed
pombredanne opened this issue Sep 1, 2022 · 1 comment
Closed

Incorrect purl type for cocoapods #3081

pombredanne opened this issue Sep 1, 2022 · 1 comment
Labels
bug

Comments

@pombredanne
Copy link
Member

Description

https://github.com/nexB/scancode-toolkit/blob/9c0f4ccca5cfc9cb79168dc888412c7246a2418d/src/packagedcode/cocoapods.py#L197 has "pods" as a purl type for cocoapods.
It should be "cocoapods" instead https://github.com/package-url/purl-spec/blob/master/PURL-TYPES.rst#cocoapods
@pombredanne pombredanne added the bug label Sep 1, 2022
AyanSinhaMahapatra added a commit that referenced this issue Sep 7, 2022
@AyanSinhaMahapatra
Correct purl type for cocoapods #3081
5647e26 
* Modify purl type for cocoapods packages and deps from `pods`
  to the correct type `cocoapods`.

Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
AyanSinhaMahapatra added a commit that referenced this issue Sep 12, 2022
@AyanSinhaMahapatra
Correct purl type for cocoapods #3081
bf78589 
* Modify purl type for cocoapods packages and deps from `pods`
  to the correct type `cocoapods`.

Reference: #3081
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
AyanSinhaMahapatra added a commit that referenced this issue Sep 12, 2022
@AyanSinhaMahapatra
Merge pull request #3096 from nexB/3081-correct-type-cocoapods
6007301 
Correct purl type for cocoapods #3081
@AyanSinhaMahapatra
Copy link
Member

Merged and released, closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pombredanne @AyanSinhaMahapatra