Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No dependency results when scanning celery-5.2.7.tar.gz #3083

Closed
JonoYang opened this issue Sep 1, 2022 · 1 comment
Closed

No dependency results when scanning celery-5.2.7.tar.gz #3083

JonoYang opened this issue Sep 1, 2022 · 1 comment
Labels
bug package scan

Comments

@JonoYang
Copy link
Member

JonoYang commented Sep 1, 2022 •
edited
Loading

Originally reported at aboutcode-org/scancode.io#516

I've downloaded, extracted, and run a package scan on https://files.pythonhosted.org/packages/ce/21/41a0028f6d610987c0839250357c1a00f351790b8a448c2eb323caa719ac/celery-5.2.7.tar.gz but no dependency results show up in the top-level dependencies field.

I think this is due to the pypi package parser getting results from the celery-5.2.7/PKG-INFO file at the root of the codebase, but it cannot find any of the dependency versions and other info because the PKG-INFO file is not in an .egg-info directory. When running the package scanning debug flags, I see that we get the dependencies when we scan celery-5.2.7/celery.egg-info/PKG-INFO.
JonoYang added a commit that referenced this issue Sep 3, 2022
@JonoYang
Prefer using PKG-INFO from .egg-info in assemble #3083
a3c875f 
    * Update test expectations

Signed-off-by: Jono Yang <jyang@nexb.com>
JonoYang added a commit that referenced this issue Sep 3, 2022
@JonoYang
Prefer using PKG-INFO from .egg-info in assemble #3083
5f4ccc7 
    * Update test expectations

Signed-off-by: Jono Yang <jyang@nexb.com>
JonoYang added a commit that referenced this issue Sep 3, 2022
@JonoYang
Prefer using PKG-INFO from .egg-info in assemble #3083
ef37a0f 
    * Add test for checking that the .egg-info PKG-INFO is the only Package source reported
    * Update test expectations

Signed-off-by: Jono Yang <jyang@nexb.com>
@JonoYang JonoYang mentioned this issue Sep 3, 2022
Merged
JonoYang added a commit that referenced this issue Sep 3, 2022
@JonoYang
Prefer using PKG-INFO from .egg-info in assemble #3083
2eb59ac 
    * Add test for checking that the .egg-info PKG-INFO is the only Package source reported
    * Update test expectations

Signed-off-by: Jono Yang <jyang@nexb.com>
JonoYang added a commit that referenced this issue Sep 6, 2022
@JonoYang
Prefer using PKG-INFO from .egg-info in assemble #3083
d6b68d2 
    * Add test for checking that the .egg-info PKG-INFO is the only Package source reported
    * Update test expectations

Signed-off-by: Jono Yang <jyang@nexb.com>
JonoYang added a commit that referenced this issue Sep 6, 2022
@JonoYang
Mark extra_requires as optional #3083
99f5034 
    * Ensure extracted_requirement contains dependency name
    * Update test expectations

Signed-off-by: Jono Yang <jyang@nexb.com>
JonoYang added a commit that referenced this issue Sep 6, 2022
@JonoYang
Mark extra_requires as optional #3083
9433eec 
    * Ensure extracted_requirement contains dependency name
    * Update test expectations

Signed-off-by: Jono Yang <jyang@nexb.com>
JonoYang added a commit that referenced this issue Sep 6, 2022
@JonoYang
Update CHANGELOG.rst #3083
1539c49 
Signed-off-by: Jono Yang <jyang@nexb.com>
JonoYang added a commit that referenced this issue Sep 6, 2022
@JonoYang
Merge pull request #3091 from nexB/3083-no-pkg-info-deps
f056c59 
Prefer using PKG-INFO from .egg-info in assemble #3083
@JonoYang
Copy link
Member Author

JonoYang commented Sep 6, 2022

Fix merged in #3091

@JonoYang JonoYang closed this as completed Sep 6, 2022
@AyanSinhaMahapatra AyanSinhaMahapatra mentioned this issue Jul 6, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug package scan
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JonoYang