Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Consider reintroducing the --license-reference option #3269

Closed
pombredanne opened this issue Feb 22, 2023 · 1 comment · Fixed by #3286
Closed

RFC: Consider reintroducing the --license-reference option #3269

pombredanne opened this issue Feb 22, 2023 · 1 comment · Fixed by #3286

Comments

@pombredanne
Copy link
Member

pombredanne commented Feb 22, 2023

After some good usage of the latest RC, we should IMHO consider reintroducing the --license-reference option and NOT always include this data in all scans. With --license-reference both rules and license reference would be included

@pombredanne
Copy link
Member Author

pombredanne commented Feb 24, 2023

In the worst case scenario if we match all the license texts and all rules, the reference will be 500MB in the JSON. This is creating a lot of boilerplate data!

We could add a --no-license-reference to turn this off for expert users.... but since the license detection and matches always include the URL to the matched license or rule, we should not make --license-reference the default.

@pombredanne pombredanne modified the milestones: v32.0, v32.1 Feb 24, 2023
AyanSinhaMahapatra added a commit that referenced this issue Mar 9, 2023
Moved license references to a CLI option and not default.

Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant