-
-
Notifications
You must be signed in to change notification settings - Fork 562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate scanner from api + other toolkit-related modules #34
Comments
@xizhao can you elaborate a bit your thought there? I am not sure I get what you meant... The scanner code proper (in the sense of walking a directory tree to do things on it) is a rather small piece of code that lives in src/scancode/ The actual scan work is done on a file-by-file basis in functions that take a file location as an input and return scan for that one file (such as detecting a license, a copyright or else). At a high level these functions are in src/scancode/api.py About Go, what would be the benefits of a rewrite? Compiled binaries bring all kinds of portability issues with them (see for instance #33 ... ) |
@xizhao do you have some more input there? |
@xizhao you wrote:
Re-reading your comment I think you meant splitting the scancode-toolkit repo in multiple repos, one |
@xizhao You never replied, so I assume that you are not interested. Closing. |
Signed-off-by: Jono Yang <jyang@nexb.com>
I think it would be valuable to have the scanner itself as a completely separate module in a different repo, or every "strategy" as separate repos. The rule aggregation is a different job than the toolkit of creating the HTML templates and other data.
Also maybe consider building the scanning module in a language like go, which can be compiled into a binary.
The text was updated successfully, but these errors were encountered: