Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong license detection for Jacoco #3515

Closed
bennati opened this issue Sep 19, 2023 · 2 comments
Closed

Wrong license detection for Jacoco #3515

bennati opened this issue Sep 19, 2023 · 2 comments
Labels
bug

Comments

@bennati
Copy link
Contributor

bennati commented Sep 19, 2023

Scancode detects license https://github.com/nexB/scancode-toolkit/tree/develop/src/licensedcode/data/rules/ace-tao_5.RULE
in file https://github.com/jacoco/jacoco/blob/master/LICENSE.md (line 13)

Tested with Scancode 32.0.6

ran the command scancode jacoco/LICENSE.md --license --license-text --license-text-diagnostics --license-diagnostics --license-references --json-pp o.json

Attached json output
o.json.zip
@bennati bennati added the bug label Sep 19, 2023
AyanSinhaMahapatra added a commit that referenced this issue Sep 19, 2023
@AyanSinhaMahapatra
Add rules and license detection updates
570c43f 
* Add new license rules from jacoco
* Add updates to the license clue heuristics

Reference: #3515
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
@AyanSinhaMahapatra
Copy link
Member

@bennati Thanks for the report!
I've added/updated rules and heuristics to account for this case and other cases like this.

@AyanSinhaMahapatra
Copy link
Member

fixed, closing!

AyanSinhaMahapatra added a commit that referenced this issue Jan 17, 2024
@AyanSinhaMahapatra
Add new license detection rules
3318ae6 
Reference: #3515
Reference: #3512
Reported-by: @bennati
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bennati @AyanSinhaMahapatra