Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--from-json allows reading from device files using a significant amount of memory #3593

Open
armijnhemel opened this issue Nov 17, 2023 · 1 comment
Labels

Comments

@armijnhemel
Copy link
Contributor

Description

Related to #3588, #3589, #3590, #3591, #3592

--from-json allows reading from device files such as /dev/zero causing scancode to use quite a bit of memory.

How To Reproduce

$ ./scancode --from-json /dev/zero --yaml /tmp/scancode.yaml
Setup plugins...
Collect file inventory...
Terminated

System configuration

For bug reports, it really helps us to know:

  • What OS are you running on? (Windows/MacOS/Linux)
  • What version of scancode-toolkit was used to generate the scan file?
  • What installation method was used to install/run scancode? (pip/source download/other)
@pombredanne
Copy link
Member

Closed in favor of #3596

pombredanne added a commit that referenced this issue Nov 24, 2023
This is to ensure that the input are regular files or directories
and that the output are writable files if they pre-exist.

This is a fix for closely related issues:

Referenced-by: #3588
Referenced-by: #3589
Referenced-by: #3590
Referenced-by: #3591
Referenced-by: #3592
Referenced-by: #3593
Referenced-by: #3594
Referenced-by: #3595
Referenced-by: #3596

Reported-by: Armijn Hemel @armijnhemel
Reported-by: Till Jaeger @LeChasseur
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants