Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version notification #111 #1688 #1708

Merged
merged 9 commits into from
Sep 3, 2019

Conversation

pombredanne
Copy link
Member

Add support for new version notifications for #111 and #1688
The principle is to check once a week if a new release has been made on PyPI and issue a warning if there a new version. No warning or failure is reported if the PyPI servers cannot be reached.

@pombredanne pombredanne force-pushed the 111-new-version-notification branch 5 times, most recently from ef77c02 to a943cf3 Compare September 3, 2019 13:45
jdaguil and others added 7 commits September 3, 2019 17:32
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne pombredanne force-pushed the 111-new-version-notification branch from 1bc148f to 65c95e3 Compare September 3, 2019 16:43
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
For #111 and #1688
We need to respect the --quiete flags

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne pombredanne force-pushed the 111-new-version-notification branch from 9e32e70 to 6bb9822 Compare September 3, 2019 17:51
@codecov
Copy link

codecov bot commented Sep 3, 2019

Codecov Report

Merging #1708 into develop will increase coverage by 0.15%.
The diff coverage is 82.14%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1708      +/-   ##
===========================================
+ Coverage    56.12%   56.27%   +0.15%     
===========================================
  Files          130      131       +1     
  Lines        16677    16761      +84     
===========================================
+ Hits          9360     9433      +73     
- Misses        7317     7328      +11
Impacted Files Coverage Δ
src/scancode/cli.py 75.87% <100%> (+0.13%) ⬆️
src/scancode/outdated.py 81.25% <81.25%> (ø)
src/packagedcode/npm.py 67.88% <0%> (+0.61%) ⬆️
src/licensedcode/seq.py 93.54% <0%> (+1.61%) ⬆️
src/textcode/markup.py 68.08% <0%> (+2.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7466489...6bb9822. Read the comment docs.

@codecov
Copy link

codecov bot commented Sep 3, 2019

Codecov Report

Merging #1708 into develop will increase coverage by 0.97%.
The diff coverage is 82.14%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1708      +/-   ##
===========================================
+ Coverage    56.12%   57.09%   +0.97%     
===========================================
  Files          130      131       +1     
  Lines        16677    16761      +84     
===========================================
+ Hits          9360     9570     +210     
+ Misses        7317     7191     -126
Impacted Files Coverage Δ
src/scancode/cli.py 75.87% <100%> (+0.13%) ⬆️
src/scancode/outdated.py 81.25% <81.25%> (ø)
src/cluecode/finder.py 68.68% <0%> (+0.35%) ⬆️
src/extractcode/archive.py 74.43% <0%> (+0.37%) ⬆️
src/licensedcode/match_set.py 76.74% <0%> (+0.58%) ⬆️
src/licensedcode/index.py 69.59% <0%> (+0.9%) ⬆️
src/typecode/contenttype.py 67.07% <0%> (+0.97%) ⬆️
src/licensedcode/query.py 62.83% <0%> (+2.13%) ⬆️
src/textcode/markup.py 70.21% <0%> (+4.25%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7466489...6bb9822. Read the comment docs.

@pombredanne
Copy link
Member Author

pombredanne commented Sep 3, 2019

This is all green now. Merging this: @jdaguil it took a while... but thank you.

@pombredanne pombredanne merged commit 1af5ac8 into develop Sep 3, 2019
@pombredanne pombredanne deleted the 111-new-version-notification branch September 3, 2019 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants