Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove RCS from list of VCS names to ignore #1748 #1766

Merged
merged 1 commit into from
Oct 17, 2019

Conversation

JonoYang
Copy link
Member

This just removes RCS from the list of VCS-related directory names in commoncode/ignore.py

Let me know if anything else should be removed also

Signed-off-by: Jono Yang <jyang@nexb.com>
@codecov
Copy link

codecov bot commented Oct 17, 2019

Codecov Report

Merging #1766 into develop will decrease coverage by 0.1%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1766      +/-   ##
===========================================
- Coverage     78.5%   78.39%   -0.11%     
===========================================
  Files          131      131              
  Lines        16736    16736              
===========================================
- Hits         13138    13121      -17     
- Misses        3598     3615      +17
Impacted Files Coverage Δ
src/commoncode/ignore.py 74.35% <ø> (ø) ⬆️
src/summarycode/generated.py 72.54% <0%> (-9.81%) ⬇️
src/licensedcode/cache.py 79.57% <0%> (-7.05%) ⬇️
src/typecode/pygments_lexers.py 52.25% <0%> (-0.65%) ⬇️
src/scancode/api.py 92.4% <0%> (-0.64%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84d5cdb...61b60c0. Read the comment docs.

@pombredanne
Copy link
Member

LGTM! merging.

@pombredanne pombredanne merged commit 7f0e3c5 into develop Oct 17, 2019
@pombredanne pombredanne deleted the 1748-stop-ignoring-rcs-dirs branch October 17, 2019 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants