Omnibus license updates July/Aug 21 #2626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No license should be detected in "License a Private" with a rule "license Private" as there is a stopword inside and this is a short rule. Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
This notice is vague and matches references to bsd-new or bsd-simplified when seen in the wild. Therefore we lower the relevance and reference bsd-new which covers also bsd-simplified. Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
This is unambiguously a CC0 license reference Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
XVId is under the gpl-2.0-plus, not the gpl-2.0. Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
These are corner cases found in handling "ignorables" clues for the latest licenses and license rules. Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
"filter_if_only_known_words_rule()" is no longer apply for small license detection rules. This was discarding too many matches. Instead the correct approach is to create false positive detection rules for the few cases that we encounter. Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Thse are now aligned with the latest copyright detection Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Return whole lines based on requested option, not based on filetype Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
pombredanne
force-pushed
the
omnibus-license-updates-july-21
branch
from
86f8c47 to
32958ca
Compare
The Debian copyright tests expected data were just a list of items without an attribute name telling what each item was. This fixes this by making the expected YAML results a dictionary rather than a list. It also adds the full match details to the expected results such that we can better assess what failed and how and can better update the tests as we improve license detection. Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
pombredanne
force-pushed
the
omnibus-license-updates-july-21
branch
from
32958ca to
5ca96d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes various improvements to license detection
and includes several new and improved license detection
rules and new licenses.