Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid misinterpreting MIT license notice as Apache-2.0, issue #2635 #2636

Merged
merged 2 commits into from
Aug 13, 2021
Merged

Avoid misinterpreting MIT license notice as Apache-2.0, issue #2635 #2636

merged 2 commits into from
Aug 13, 2021

Conversation

petergardfjall
Copy link
Contributor

@petergardfjall petergardfjall commented Aug 13, 2021 •
edited
Loading

Fixes #2635

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁

@petergardfjall
adds MIT detection rule 1055
1bab112 
This provides a rule that matches MIT notices of form (note: indent for highlight):

  License

  This project is licensed under the terms of the MIT license.

Signed-off-by: Peter Gardfjäll <peter.gardfjall.work@gmail.com>
@petergardfjall
apache-2.0_328.RULE: set minimum_coverage to 70
0632f33 
This avoids Apache-2.0 "overriding" mit_349.RULE in cases like

  ## License

  This project is licensed under the terms of the MIT license.

Signed-off-by: Peter Gardfjäll <peter.gardfjall.work@gmail.com>
@petergardfjall petergardfjall changed the title Avoid misinterpreting MIT license notice as Apache-2.0 Issue #2635 Avoid misinterpreting MIT license notice as Apache-2.0, issue #2635 Aug 13, 2021
@petergardfjall petergardfjall mentioned this pull request Aug 13, 2021
Open
pombredanne
pombredanne approved these changes Aug 13, 2021
View reviewed changes
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean, neat and nice.
Thank you ++

@pombredanne pombredanne merged commit 6bf2fd9 into aboutcode-org:develop Aug 13, 2021
@pombredanne pombredanne mentioned this pull request Aug 13, 2021
Closed
7 tasks
@petergardfjall petergardfjall deleted the issue-2635 branch August 16, 2021 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pombredanne pombredanne pombredanne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Apparent MIT license gets discovered as Apache-2.0
2 participants
@petergardfjall @pombredanne