Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2789 inconsistent doc html app #2795

Merged
merged 3 commits into from
Jan 24, 2022
Merged

2789 inconsistent doc html app #2795

merged 3 commits into from
Jan 24, 2022
+7 −3

Conversation

kunalchhabra37
Copy link
Contributor

@kunalchhabra37 kunalchhabra37 commented Jan 13, 2022 •
edited
Loading

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁

@kunalchhabra37
Update output-format.rst
9e45c77 
Signed-off-by: Kunal Chhabra <kunalchhabra37@gmail.com>
@kunalchhabra37
Update CHANGELOG.rst
9b4043e 
Signed off by: Kunal Chhabra <kunalchhabra37@gmail.com> fixed inconsistency in documentation aboutcode-org#2789
@kunalchhabra37
Update AUTHORS.rst
580ba6b 
Signed off by- Kunal Chhabra <kunalchhabra37@gmail.com>
pombredanne
pombredanne approved these changes Jan 24, 2022
View reviewed changes
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kunal: Thank you ... well spotted!

There are some inconsistencies in your DCO signoff, but one of them is good, so I will squash and merge.

@pombredanne pombredanne merged commit 0e4fe27 into aboutcode-org:develop Jan 24, 2022
@pombredanne
Copy link
Member

Thanks again! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pombredanne pombredanne pombredanne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kunalchhabra37 @pombredanne