Fix GPL license detection false positive #2793 #2799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a false-positive rule for a file in Android. Fixes aboutcode-org#2793. Signed-off-by: Kevin Ji <kyji1011@gmail.com>
pombredanne
approved these changes
Jan 24, 2022
There was a problem hiding this comment.
Kevin: Thank you ++
This is great. 🙇
I will not bug you for the missing signing DCO on 4b76d13 since you already have it on the other commit!
LGTM, merging!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a false-positive rule for a file in Android. Fixes #2793.
Tasks
Run tests locally to check for errors.