Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix small typo inside notes snippet #2829

Merged
merged 4 commits into from
Mar 4, 2022
Merged

Fix small typo inside notes snippet #2829

merged 4 commits into from
Mar 4, 2022

Conversation

Harshil-Jani
Copy link
Contributor

@Harshil-Jani Harshil-Jani commented Feb 1, 2022 •
edited
Loading

Small Fix

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 📑
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁

Signed-off-by: Harshil Jani harshiljani2002@gmail.com

pombredanne
pombredanne requested changes Feb 3, 2022
View reviewed changes
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
We typically want your Signed-off-by: Harshil Jani harshiljani2002@gmail.com signoff in the commit message. I reckon this is a small fix, but still, would you mind to amend your commit message?

pombredanne
pombredanne requested changes Feb 10, 2022
View reviewed changes
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Do you mind to try to squash your commits in a single one with proper DCO?
You can join https://gitter.im/aboutcode-org/discuss for help too

@pombredanne
Copy link
Member

gentle ping ....
Do you mind to try to squash your commits in a single clean one?

@pombredanne
Copy link
Member

Thanks! Do you mind to try to squash your commits in a single one with proper DCO?

gentle ping

pombredanne
pombredanne approved these changes Mar 4, 2022
View reviewed changes
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pombredanne pombredanne merged commit 1dc4b61 into aboutcode-org:develop Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pombredanne pombredanne pombredanne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Harshil-Jani @pombredanne