New license and copyright rule #2837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityasangave
force-pushed
the
2798_fix
branch
from
e4989b7 to
7cfd344
Compare
|
@pombredanne review, any changes ? |
pombredanne
reviewed
Feb 2, 2022
| @@ -2562,6 +2562,9 @@ def build_detection_from_node( | |||
| #holder is Tim Hudson (tjh@mincom.oz.au). | |||
| COPYRIGHT: {<HOLDER> <JUNK> <NAME-EMAIL>} #83001 | |||
|
|
|||
| # Copyright lowRISC contributors. | |||
| COPYRIGHT: {<COPY> <NN> <CONTRIBUTORS>} | |||
|
|
|||
There was a problem hiding this comment.
That's great! do you mind to add a test for this too?
pombredanne
requested changes
Feb 2, 2022
There was a problem hiding this comment.
See https://github.com/nexB/scancode-toolkit/blob/develop/tests/cluecode/cluecode_test_utils.py and https://github.com/nexB/scancode-toolkit/tree/develop/tests/cluecode/data/copyrights for pairs of test file/expected results in YAML.
Signed-off-by: adii21-Ux <adityasangave2112@gmail.com>
Signed-off-by: adii21-Ux <adityasangave2112@gmail.com>
adityasangave
force-pushed
the
2798_fix
branch
2 times, most recently
from
71a36fb to
a8527a3
Compare
Signed-off-by: adii21-Ux <adityasangave2112@gmail.com>
adityasangave
force-pushed
the
2798_fix
branch
from
a8527a3 to
ff318bd
Compare
pombredanne
approved these changes
Feb 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2798
Tasks
Run tests locally to check for errors.