Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not raise exception on package data mismatch #2886 #2887

Merged
merged 1 commit into from
Mar 9, 2022
Merged

Do not raise exception on package data mismatch #2886 #2887

merged 1 commit into from
Mar 9, 2022

Conversation

AyanSinhaMahapatra
Copy link
Member

@AyanSinhaMahapatra AyanSinhaMahapatra commented Mar 9, 2022 •
edited
Loading

Do not raise exceptions and fail in package instance creation
if there is name/type/version mismatch between detected
package_data. Adds test to verify.

Signed-off-by: Ayan Sinha Mahapatra ayansmahapatra@gmail.com

Fixes #2886

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁

@AyanSinhaMahapatra
Do not raise exception on package data mismatch #2886
65a0fc5 
Do not raise exceptions and fail in package instance creation
if there is name/type/version mismatch between detected
package_data. Adds test to verify.

Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
@JonoYang
Copy link
Member

JonoYang commented Mar 9, 2022

@AyanSinhaMahapatra

LGTM! I've tested this out on a scan of setuptools-58.2.0 and I do not get any errors. I was getting errors when scanning this package before these changes. I will merge this in when all the CI tests pass.

Thank you!

@JonoYang JonoYang merged commit 7462158 into develop Mar 9, 2022
@JonoYang JonoYang deleted the fix-2886-packages branch March 9, 2022 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pombredanne pombredanne pombredanne left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Do not raise exception on name/type mismatch for package instance creation
3 participants
@AyanSinhaMahapatra @JonoYang @pombredanne