Fix #3157 by changing CFG_BIN_DIR
#3158
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Earlier, it was $VIRTUALENV_DIR/bin. This commit fixes Issue #3157. Signed-off-by: Abhishek Kumar <abhi.kr.2100@gmail.com>
Issue #3157 affects only those who have a local installation of pip. As such, changing `CFG_BIN_DIR` to `local/bin` will break `configure` for everyone else. This commit ensures that CFG_BIN_DIR uses the usual directory and falls back to `local/bin` only when the usual directory doesn't exist BUT the `local/bin` directory does exist. Signed-off-by: Abhishek Kumar <abhi.kr.2100@gmail.com>
|
Closing per #3157 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The older value of
CFG_BIN_DIRwas$CFG_ROOT_DIR/$VIRTUALENV_DIR/bin. However, as mentioned in #3157, the bin directory actually was in$CFG_ROOT_DIR/$VIRTUALENV_DIR/local/bin.Fixes #3157
Tasks
Run tests locally to check for errors.
Signed-off-by: Abhishek Kumar abhi.kr.2100@gmail.com