Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix maven pom resource assignment #3427

Merged
merged 2 commits into from
Jun 12, 2023
Merged

Fix maven pom resource assignment #3427

merged 2 commits into from
Jun 12, 2023

Conversation

AyanSinhaMahapatra
Copy link
Member

@AyanSinhaMahapatra AyanSinhaMahapatra commented Jun 12, 2023 •
edited
Loading

This introduces a fix where we don't assign resources to packages when we
find multiple pom.xmls in a META-INF directory for a jar.

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁
  • Looked for possible updates in documentation and added updates if applicable
  • Updated CHANGELOG.rst

@AyanSinhaMahapatra
Copy link
Member Author

@pombredanne ready for initial review, please take a look

@AyanSinhaMahapatra
Add tests to fix for maven resource assignment
23def6c 
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
@AyanSinhaMahapatra
Do not assign resources in uberjars
ff81f96 
This introduces a fix where we don't assign resources to packages when we
find multiple pom.xmls in a META-INF directory for a jar.

Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
@AyanSinhaMahapatra AyanSinhaMahapatra force-pushed the fix-maven-pom-resource-assign branch from 5b0e46c to ff81f96 Compare June 12, 2023 11:18
@pombredanne pombredanne changed the title Fix maven pom resource assign Fix maven pom resource assignment Jun 12, 2023
pombredanne
pombredanne approved these changes Jun 12, 2023
View reviewed changes
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a minor nit.... You may want to add a test for the case when there is single pom too

@AyanSinhaMahapatra AyanSinhaMahapatra merged commit a001800 into develop Jun 12, 2023
@pombredanne pombredanne deleted the fix-maven-pom-resource-assign branch June 29, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pombredanne pombredanne pombredanne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AyanSinhaMahapatra @pombredanne