Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release prep v32.0.5rc3 #3436

Merged
merged 2 commits into from
Jun 23, 2023
Merged

Release prep v32.0.5rc3 #3436

merged 2 commits into from
Jun 23, 2023

Conversation

AyanSinhaMahapatra
Copy link
Member

Reference: #3435

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁
  • Looked for possible updates in documentation and added updates if applicable
  • Updated CHANGELOG.rst

Reference: #3435

Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
@AyanSinhaMahapatra
Copy link
Member Author

Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Keep in mind to eventually merge all the RC changelog entries in one for 32.0.5
Also I wonder if we need so many RCs for a minor dot release

@AyanSinhaMahapatra
Copy link
Member Author

Thanks @pombredanne

Keep in mind to eventually merge all the RC changelog entries in one for 32.0.5

Sure, I'll do that. The rc2 and rc3 are minor though, without any material changes.

Also I wonder if we need so many RCs for a minor dot release

The first RC had was created because we merged the license detections and improvements branch. This failed with the pypi upload limit bug, but this already had published a pypi release with the source archive as it was under the limit. So it would have been problematic to yank from pypi, delete the github release, and then also force push the tag.
Second time we did not change anything in code, just bump after the new pypi limit was approved. So I did not test the release scripts again because there was no code changes (my bad, should have done a check anyway, it failed because of other changes). Here I did not want to delete the tag and force push it again as it was there for more than a day as I was trying to figure out the issue. If it was not much time I'd have fixed and force-pushed the tag allright.
That is why we have 3 rcs for a dot release which should not have happened ideally. 😅

Merging thanks!

@AyanSinhaMahapatra AyanSinhaMahapatra merged commit 2da060a into develop Jun 23, 2023
@AyanSinhaMahapatra AyanSinhaMahapatra deleted the release-prep-v32.0.5rc3 branch June 23, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants