Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

License rules update #3545

Merged
merged 29 commits into from
Oct 11, 2023
Merged

License rules update #3545

merged 29 commits into from
Oct 11, 2023

Conversation

AyanSinhaMahapatra
Copy link
Member

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁
  • Looked for possible updates in documentation and added updates if applicable
  • Updated CHANGELOG.rst

pombredanne and others added 15 commits October 3, 2023 10:29
@pombredanne
Ensure that rule is detected continuously
480763f 
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne
Make frontmatter template configurable
3d04cc9 
This make it usable to in the buidlrules.py ect/ script

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne
Optionally dump errors in a formatter file
b1ec123 
The new -d option optionally dumps errors in a text file instead of
reporting them on screen.

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne
Add misc new license detection rules
499257c 
This is a batch of new license detection rules collected over the summer

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne
Add new misc. license rules
1890429 
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne
Add rules to avoid false positive detection
1d43b76 
Reference: #3533
Reported-by: Omair Majid @omajid
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne
Add new and improved license detection rules
6bae0d5 
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne
Add misc. alternative SDPX keys for MIT
3058f7f 
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne
Improve rule to avoid false proprietary detection
68b5173 
Reference: #3532
Reported-by: Omair Majid @omajid
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne
Add new and improved license detection rules
2facd79 
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne @AyanSinhaMahapatra
Update unknown_license_other_12.RULE
bf3d854 
Ensure this is detected as a solid sentence

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne @AyanSinhaMahapatra
Add new generated clues for JavaCC
7039e3e 
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne @AyanSinhaMahapatra
Deprecate noisy rules
a17bc5f 
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne @AyanSinhaMahapatra
Improve JSON license detection rules #3534
e50169f 
* Make these rules more discriminant by adding key phrases.
* Add test for #3534

Reported-by: Matt Thalman @mthalman
Reference: #3534
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@AyanSinhaMahapatra
Update tests to fix CI errors
d766940 
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
@AyanSinhaMahapatra AyanSinhaMahapatra force-pushed the license-rules-update-fall-2023-1 branch from 366a11c to d766940 Compare October 10, 2023 11:42
@AyanSinhaMahapatra AyanSinhaMahapatra mentioned this pull request Oct 10, 2023
Closed
6 tasks
@AyanSinhaMahapatra
Add new maven license rule
a22e25b 
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
@AyanSinhaMahapatra AyanSinhaMahapatra force-pushed the license-rules-update-fall-2023-1 branch from 071698e to a22e25b Compare October 11, 2023 06:41
AyanSinhaMahapatra and others added 11 commits October 11, 2023 12:57
@AyanSinhaMahapatra
Fix tests in CI
58db9cd 
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
@pombredanne
Improve rule to avoid false proprietary detection
0e39067 
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne
Make rule more selective
0217506 
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne
Improve detection of LZMA SDK license
0e0aeb3 
Reference: #3543
Reported-by: Omair Majid @omajid
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne
Do not detect spurrious JSON license
1f8af54 
Reference: #3531
Reported-by: Omair Majid @omajid
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne
Test license rule flags correctly
fff1be6 
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne
Do not detect spurrious proprietary license
238a075 
Reference: #3543
Reported-by: Omair Majid @omajid
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne
Demote these lesser rule to mere clue
7bc1e09 
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne
Add license detection test
a56c665 
Reference: #3543
Reported-by: Omair Majid @omajid
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne
Add license detection test
2cd6ad4 
Reference: #3531
Reported-by: Omair Majid @omajid
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne
Add license detection test
15f6e47 
Reference: #3532
Reported-by: Omair Majid @omajid
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne pombredanne force-pushed the license-rules-update-fall-2023-1 branch from ebdb1ea to 0b01672 Compare October 11, 2023 08:20
@pombredanne
Add license detection test
74c0d6c 
Reference: #3537
Reported-by:  Stefano Bennati @bennati
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne pombredanne force-pushed the license-rules-update-fall-2023-1 branch from 0b01672 to 74c0d6c Compare October 11, 2023 09:37
@AyanSinhaMahapatra
Merge branch 'develop' into license-rules-update-fall-2023-1
8504274 
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
@AyanSinhaMahapatra
Copy link
Member Author

All green!
Thanks @pombredanne for the updates, merging this now.

@AyanSinhaMahapatra AyanSinhaMahapatra merged commit 8567120 into develop Oct 11, 2023
33 checks passed
@AyanSinhaMahapatra AyanSinhaMahapatra deleted the license-rules-update-fall-2023-1 branch October 11, 2023 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AyanSinhaMahapatra @pombredanne