Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update debian package manifest parsing #3647

Merged
merged 8 commits into from
Feb 19, 2024

Conversation

AyanSinhaMahapatra
Copy link
Member

@AyanSinhaMahapatra AyanSinhaMahapatra commented Jan 29, 2024

We will now deduce and populate debian distro information, i.e. their namespace from clues present in version/maintainer info.

Reference: aboutcode-org/scancode.io#899
Supports: https://pypi.org/project/debian-inspector/31.1.0/

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁
  • Updated documentation pages (if applicable)
  • Updated CHANGELOG.rst (if applicable)

We will now deduce and populate debian distro information, i.e. their
namespace from clues present in version/maintainer info.

Reference: aboutcode-org/scancode.io#899

Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
Supports scanning .dsc and _copyright files
from debain package and metadata archives for
package metadata.

Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
@AyanSinhaMahapatra AyanSinhaMahapatra changed the title Set debian namespace from clues Update debian package manifest parsing Feb 19, 2024
See https://github.com/package-url/purl-spec/blob/master/PURL-TYPES.rst#deb
Here `arch is the qualifiers key for a package architecture`, and we
were using architecture, which was a bug. This commit is a fix for that.

Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!
Thanks.

Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
@AyanSinhaMahapatra AyanSinhaMahapatra merged commit 79aae34 into develop Feb 19, 2024
6 of 34 checks passed
@AyanSinhaMahapatra AyanSinhaMahapatra deleted the fix-debian-namespace branch February 19, 2024 15:39
@AyanSinhaMahapatra AyanSinhaMahapatra added this to the v32.1 milestone Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants