-
-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve debian package detection #3723
Conversation
bd8cfcf
to
349d95b
Compare
Detect and store more attributes from debian .dsc metadata files. Also properly detect and create packages from control and md5sums files. Reference: aboutcode-org/scancode.io#1151 Reference: aboutcode-org/purldb#3 Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
349d95b
to
43dc430
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
Yet I think we can do better.
See https://en.wikipedia.org/wiki/Deb_(file_format)#Implementation
We should support xz, lzma, bz2, gz and zst AND the data.tar and control.tar may be uncompressed too
See also:
- https://gitlab.com/gitlab-org/gitlab/-/issues/422584
- https://gitlab.com/pmhahn/debian-package-registry
@pmhahn do you reckon we should support all of .tar.xz, .tar.lzma, .tar.bz2, .tar.gz, .tar.zst, .tar.zstd AND the plain data.tar and control.tar as formats for the tarballs inside a .deb? We need to support all current but also legacy formats to properly scan and index them!
@pmhahn are the packages in https://gitlab.com/pmhahn/debian-package-registry testing all known formats? @AyanSinhaMahapatra to build all these combos in a Ci/CD test (likely from our own clone for stability):
|
@AyanSinhaMahapatra https://wiki.debian.org/Teams/Dpkg/DebSupport gives some visibility on the topic |
As I noted in the Gitlab issue the problem is that newer But as |
@pmhahn good point! Thank you ++ for your swift reply! .... @AyanSinhaMahapatra let's support them all then as this has no downside. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks
Reference: aboutcode-org/scancode.io#1151
Reference: aboutcode-org/purldb#3
Tasks
Run tests locally to check for errors.