Improve copyrights detection #3752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reported-by: Dimitris Iliou @dimitris-iliou Reference: #3735 Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Spotted in some common python libraries such as numpy and scipy Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Use an input file where each line is either: - a URL to fetch - a text to test Then generate a test data files pair accordingly Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
- Start detecting "is held by" - Do not include some trailing junk Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
This makes copyright detection more specific Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Also improve NOTICEs, and other misc. variants Don not detect "The Initial Developer" Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Handle corner cases with markup Detect new copyright forms. Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
* Handle better various parens, markup and quotes Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
AyanSinhaMahapatra
requested changes
Jun 10, 2024
There was a problem hiding this comment.
@pombredanne we need to fix the test failures here and after regenerating it seems to me like some of these are regressions potentially, we need more review of these failures.
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
pombredanne
changed the title
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
|
@AyanSinhaMahapatra ready for your review, all greeen |
AyanSinhaMahapatra
approved these changes
Jun 24, 2024
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com> Co-authored-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
AyanSinhaMahapatra
approved these changes
Jun 26, 2024
There was a problem hiding this comment.
LGTM! Thanks++ @pombredanne This improves copyright detection a lot!
Merging!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves copyright detection
Tasks
Run tests locally to check for errors.